Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cae6862) 36.36% compared to head (1cdcf58) 36.34%.

@@            Coverage Diff             @@
##            devel     #940      +/-   ##
==========================================
- Coverage   36.36%   36.34%   -0.02%     
==========================================
  Files          42       42              
  Lines        7890     7891       +1     
==========================================
- Hits         2869     2868       -1     
  Misses       4849     4849              
- Partials      172      174       +2     

... and 2 files with indirect coverage changes

lets set to enabled by default instead of auto

auto doesn't function correctly

lets set to enabled by default instead of auto

auto doesn't function correctly

The switch case in this PR only sets the reconnect behaviour to false in two cases:
When the env var is set to disabled
When the env var is set to something other than the three cases (enabled, disabled,auto)

All other cases are set to true. So "default" is true unless garbage is given. Is this the behaviour you are expecting?

Quality Gate failed

Failed conditions

33.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@TheRealHaoLiu The comments needed clarification, thanks for the catch!

need to validate support version range of OCP with supported version of Controller to make sure we are currently not supporting any OCP that do not have the log timestamp bug